search

mortuusars / Exposure

Camera mod for Minecraft with focus on process and aesthetics.
https://www.curseforge.com/minecraft/mc-mods/exposure
94 stars 20 forks source link

[Amarite Incompatibility] - Crash when holding a photograph [1.19.2, Quilt] #45

Closed UmbralSurvivor closed 8 months ago

UmbralSurvivor commented 9 months ago

Might also affect fabric. crash-2024-02-06_23.09.50-client.txt

I'm on a server with a custom modpack, if that affects anything.

UmbralSurvivor commented 9 months ago

Happens when scrolling items/changing slots to a Photograph

UmbralSurvivor commented 9 months ago

crash-2024-02-07_13.14.20-client.txt Previous crash report gave a false positive on the issue

mortuusars commented 9 months ago

This is a known conflict with Amarite. And since their mod is not open source I don't know what they do to make it not work as it should.

I'm not seeing anyting wrong on my part: 

if (stack.getItem() instanceof PhotographItem || stack.getItem() instanceof StackedPhotographsItem) {
            if (isMainHand && this.offHandItem.isEmpty()) {
                exposure$renderTwoHandedPhotograph(player, poseStack, buffer, combinedLight, pitch, equipProgress, swingProgress);
            } else {
                exposure$renderOneHandedPhotograph(player, poseStack, buffer, combinedLight, equipProgress, arm, swingProgress, stack);
            }

            poseStack.popPose();

            ci.cancel();
        }

Item Stack is ensured to be a photograph (or a stack of photographs) before rendering. How they make it be air (empty) after that is beyond me.

mortuusars commented 8 months ago

This seems to have been fixed in Exposure 1.4.0