search

mos3abof / power-close

A browser addon for the tab addict that closes tabs based on domain name or keyword
https://www.power-close.com/
GNU General Public License v2.0
20 stars 10 forks source link

Doesnt work ... dud addon #16

Open circuitikzuser opened 2 years ago

circuitikzuser commented 2 years ago

Just to mention my experience. I needed an addon in firefox that will close a tab containig a certain phrase. Installed power-close, entered the phrase in the text box from the menu icon created and nothing happens. It does squat and the Tab still remains . I tried putting the phrase in quotation marks and that didnt work either.

mos3abof commented 2 years ago

Thank you for your feedback. Just to make sure I understand, was the phrase part of the URL of the tab you are closing? Or was it part of the content of the tab? The addon does not support the latter.

circuitikzuser commented 2 years ago

Content.

mos3abof commented 2 years ago

I see. This is not yet supported. Will try to add support for that in the future.

circuitikzuser commented 2 years ago

Ok thanks, There is never any purpose for me to close down tabs containing a url so I assumed it was for body text. , but there is a huge need for closing down tabs containing a string of text.

shmup commented 2 years ago

Ok thanks, There is never any purpose for me to close down tabs containing a url so I assumed it was for body text. , but there is a huge need for closing down tabs containing a string of text.

Is there though? It never occurred to me to close any tabs based on this method. Or any vim buffers. Or, the list goes on.

circuitikzuser commented 1 month ago

Of course there is. If there are sites with explicit text you want to avoid then this will be great to just close all those tabs containing the text as mentioned as it is time consuming closing them all.

One example is is for auction sites which you batch open in tabs for results as items found for a query. It always returns tabs with no results and always state fix text on the return. It would be nice to batch close all those tabs, as it is time consuming closing them manually. This is only one case. Will save a huge amount of time.

shmup commented 1 month ago

@circuitikzuser I absolutely came around to your idea even when I read it again the other day!

We can do it. Back then I forked this project and made it my own:

image

At the time I wanted to be able to type multiple strings into the input at once, to match many tabs.

I think with your wishes, it'd be best to have this be a preference, such as a toggle in the popup, or a !flag of some sort. What do you think? I just don't want it to be default.

For this, I'd likely just fork/contribute the changes to this repo, and not mine. Mine is too personalized now for anyone lol

@mos3abof can you open this back up? I will contribute the change, once we decide the best way this feature can be utilized

mos3abof commented 1 month ago

This is an interesting discussion! Did not expect the conversation to be live after all these years :)

circuitikzuser commented 1 month ago

This will be great, but wont forking create a lot of problems maintaining it ? Anyway it would be great.

Just a note: In my case, the text that should trigger the tab close, is usually in the BODY of the page. Just in case we misunderstand each other. I dont know if that would be more difficult, but sure would be nice ?

circuitikzuser commented 1 month ago

As an example. Pages to be closed will e.g. contain the following text in the body. "Item not found, please change search terms" So I want to close all open tabs with that text in the body.