mosa / MOSA-Project

Managed Operating System Alliance Project
https://www.mosa-project.org/
Other
406 stars 82 forks source link

Update to .NET 8.0, Avalonia 11.0.9 and fix launcher issue #1189

Closed AnErrupTion closed 4 months ago

AnErrupTion commented 4 months ago
AnErrupTion commented 4 months ago

Missing some changes, the Directory.Build.props file needs to be updated as well as korlib

The props file is already updated, maybe you didn't see it? Also, Korlib doesn't need to be updated (just like the other BareMetal projects) because it uses the Mosa.BareMetal.targets file, which should itself use the target framework set in Directory.Build.props.

charsleysa commented 4 months ago

Sorry, don't know how I missed that the Directory.Build.props file was already updated.

In regards to korlib, I believe this line has to be updated to match the dotnet version https://github.com/mosa/MOSA-Project/blob/2eeffe43249819413c472f225a61963fb7c0e32e/Source/Mosa.Korlib/Mosa.Korlib.csproj#L10

AnErrupTion commented 4 months ago

In regards to korlib, I believe this line has to be updated to match the dotnet version

Oh yeah I forgot about the assembly version! It's not technically required to update it, but it makes things more consistent. Thanks! It's updated now :D