Implement ERC20::Cogateway::confirmDeposit()

mosaicdao / mosaic-1

Mosaic-1 : meta-blockchains on Ethereum 1.x

8 stars 12 forks source link

Implement ERC20::Cogateway::confirmDeposit() #298

Closed Vindeep07 closed 4 years ago

Vindeep07 commented 4 years ago

Fixes #274

Implements ERC20Cogateway::confirmDeposit()
~~Proof for ERC20Cogateway::deposit()~~
~~Partial Unit test~~

Please note: Unit tests cannot be written for this because with every deployment the channel identifier will change. The generated proof cannot be used in the unit test.

deepesh-kn commented 4 years ago

Contract implementation looks good 👍 We can add unit tests by setting channel identifier in double.

👍 sure, I will suggest merging this PR related to the contract so that the next tickets get unblocked. We can keep this ticket open and create one more ticket for the unit test for the same ticket.