mosaicml / composer

Supercharge Your Model Training
http://docs.mosaicml.com
Apache License 2.0
5.06k stars 407 forks source link

Add buffering time to mlflow logger #3401

Closed chenmoneygithub closed 2 weeks ago

chenmoneygithub commented 2 weeks ago

What does this PR do?

Add buffering time to mlflow logger, tested with unit test along with manual testing.

What issue(s) does this change relate to?

Before submitting

mvpatel2000 commented 2 weeks ago

qq: does this actually need to be configurable? or should you just pick a good default value?

Hm yea @chenmoneygithub can we set a default at least to something you'd like? maybe 5s?

chenmoneygithub commented 2 weeks ago

I am putting 10s for now.