search

mosaicnetworks / monetd

Distributed smart-contract platform based on EVM-Lite and Babble
MIT License
12 stars 4 forks source link

POA duplicate nominees #26

Open arrivets opened 4 years ago

arrivets commented 4 years ago

It is possible to nominate the same address twice, which messes things up. The same is probably true of evictees as well.

jonknight73 commented 4 years ago

Recompiling the master contract with solc version 0.5.11 I cannot reproduce thus behaviour. The generated bytecode.go file does have differences in the generated bytecode. I will investigate further, but if the contract can be shown to be working with a more current compiler version, I would be minded to set the pragma in solidity to the working version or higher.

arrivets commented 4 years ago

Creating duplicate nominees is no longer possible but there is another problem.

A whitelist member cannot vote for the same nominee in different ballots.

Ex: Alice is a nominee Bob votes for her ( yes or no, doesn't matter) Alice's application is rejected ( someone voted no ) - she gets ejected from the nominee list Alice gets nominated again Bob tries to vote for her again ----> BREAKS

jonknight73 commented 4 years ago

Fixed in 4cd2afd8a36bb9de3dbf914ab5e9394600542f52 in develop. Will be promoted to master in the release later today.