search

moscajs / aedes-persistence-mongodb

MongoDB persistence for Aedes
MIT License
14 stars 16 forks source link

Improvments #36

Closed robertsLando closed 4 years ago

robertsLando commented 4 years ago
robertsLando commented 4 years ago

Should I create a minor or a major of this once merged?

On 2 Mar 2020, at 18:30, Matteo Collina notifications@github.com wrote:

 @mcollina approved this pull request.

lgtm

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mcollina commented 4 years ago

this seems to be a minor, is it a breaking change?

robertsLando commented 4 years ago

escape-string-regexp drops nodejs 8 support. I will also remove it from github action tomorrow. So I think it should be a major

On 2 Mar 2020, at 20:11, Matteo Collina notifications@github.com wrote:

 this seems to be a minor, is it a breaking change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

mcollina commented 4 years ago

Make it a major Il 2 mar 2020, 20:30 +0100, Daniel Lando notifications@github.com, ha scritto:

escape-string-regexp drops nodejs 8 support. I will also remove it from github action tomorrow. So I think it should be a major

On 2 Mar 2020, at 20:11, Matteo Collina notifications@github.com wrote:

this seems to be a minor, is it a breaking change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

robertsLando commented 4 years ago

Could you also check the PR #33 of this repo? I would like to merge that too before the release

On 2 Mar 2020, at 21:32, Matteo Collina notifications@github.com wrote:

Make it a major Il 2 mar 2020, 20:30 +0100, Daniel Lando notifications@github.com, ha scritto:

escape-string-regexp drops nodejs 8 support. I will also remove it from github action tomorrow. So I think it should be a major

On 2 Mar 2020, at 20:11, Matteo Collina notifications@github.com wrote:

this seems to be a minor, is it a breaking change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

robertsLando commented 4 years ago

@mcollina Still LGTM? Can I go on with this and make a major release?

robertsLando commented 4 years ago

@mcollina ping

robertsLando commented 4 years ago

@mcollina Major release? We have dropped nodejs 8 here

mcollina commented 4 years ago

definitely! Il 17 mar 2020, 08:47 +0100, Daniel Lando notifications@github.com, ha scritto:

@mcollina Major release? We have dropped nodejs 8 here — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

robertsLando commented 4 years ago

Wait a moment there are some outdated deps