search

moscajs / aedes-persistence-mongodb

MongoDB persistence for Aedes
MIT License
14 stars 16 forks source link

feat: Add incoming and outgoing collection query indexes #65

Closed scagood closed 3 years ago

scagood commented 3 years ago

This addes the indexes from #64

scagood commented 3 years ago

:thinking: It works on mongo 4.0 not mongo 4.4 due to the expireAfterSeconds being present in the index options object, fixing then force pushing.

scagood commented 3 years ago

I have tested in node 10, 12, 13, and 14 against mongo 4.0, 4.2, and 4.4 and I cant reproduce this error in the CI. (Ive done node 13 <-> mongo 4.4 many times now :sweat:)

This is the failing test aedes-persistence/abstract.js:770. I think the subscriptionsByClient response is valid as it contains the correct subscriptions just in a different order.

This could be resolved by adding a .sort() call or something, but I think the abstract test should be changed instead.

mcollina commented 3 years ago

Totally, could you send a PR to the abstract tests making that check order independent?

robertsLando commented 3 years ago

@scagood You can bump aedes-persistence now

scagood commented 3 years ago

:thinking: aedes-persistence is not in the package.json, should I add it there as a dev dependency?

robertsLando commented 3 years ago

It is not there because it is a dep of aedes-cached-persistence, you should run npm update --depth 1 I think would be enough, I will bump aedes-cached-persistence too

robertsLando commented 3 years ago

https://github.com/moscajs/aedes-cached-persistence/pull/46

robertsLando commented 3 years ago

@scagood You can now bump aedes-cached-persistence to 8.1.1

robertsLando commented 3 years ago

@mcollina ping?

robertsLando commented 3 years ago

@scagood Released :tada:

robertsLando commented 3 years ago

@scagood Are you interested to join our moscajs org? Actually I'm the only maintainer and every help would be more then welcome, @mcollina is the author of aedes but doesn't have time to contribute with the code, just code reviews

scagood commented 3 years ago

I'm totally happy to contribute code (and review code) where needed, but Im not sure I want to be a maintainer at this point as I dont really have the time to dedicate to it, thank you for the offer though :sweat_smile: