search

moscajs / aedes-persistence

In-memory implementation of an Aedes persistence, with abstract tests
MIT License
13 stars 22 forks source link

feat: persist rh, rap, nl #87

Closed oldrich-s closed 2 years ago

oldrich-s commented 2 years ago

Hi,

I am working on fixing Aedes bridge connection where nl flag is not respected:

https://github.com/moscajs/aedes/issues/736

For that I need to update aedes-persistence to persist nl, rap and rh flags.

The tests are still failing because qlobber also needs to be updated to work with nl, rap and rh flags:

https://github.com/davedoesdev/qlobber/pull/24

So this pull request needs to wait until qlobber is updated. 👍

robertsLando commented 2 years ago

Changes looks good. I think there would need some changes also to (in order):

cc @mcollina @gnought @seriousme

seriousme commented 2 years ago

Changes looks good. I think there would need some changes also to (in order):

cc @mcollina @gnought @seriousme

FYI: I'm working to add this feature to https://github.com/moscajs/aedes-persistence-level

Kind regards, Hans

oldrich-s commented 2 years ago

I have updated qlobber dependency to 7.0.0 and fixed the remaining failing unit tests so I think that the PR is ready 👍.

robertsLando commented 2 years ago

9.1.0 is out now. Thanks @oldrich-s

oldrich-s commented 2 years ago

Dont know if it has any influence but aedes-packet dependency could probably be updated to v3.0.0 before releasing new version

EDIT: you were faster 😁

robertsLando commented 2 years ago

Argg missed it, let me create a quick patch

robertsLando commented 2 years ago

Done