search

moscajs / ascoltatori

The pub/sub library for node backed by Redis, MongoDB, AMQP (RabbitMQ), ZeroMQ, MQTT (Mosquitto) or just plain node!
http://mcollina.github.com/ascoltatori
524 stars 122 forks source link

Upgrade the ascoltatori kafka broker to kafka-node 4.0.0 #195

Open karthicks opened 5 years ago

karthicks commented 5 years ago

It appears that, currently, KafkaAscoltatore depends on an older ~0.5.8 version of kafka-node, and uses deprecated methods thereof, such as kafka.Client. Would it be possible to upgrade to kafka-node 4.0.0, and use the recommended kafka.KafkaClient instead, which connects directly to the kafka brokers, as opposed to going through zookeeper?

user1m commented 5 years ago

+1 facing this issue as well. Doesn't look like this library is up to date w/ kafka-node

vicary commented 5 years ago

This issue also prevents snappy support for node 12.

user1m commented 5 years ago

@vicary we built a PubSub wrapper around kafka-node if you're using Kafka as your backing/broker. Check out: https://github.com/NeuCleans/kafka-pub-sub

vicary commented 5 years ago

@User1m This is in fact an indirect dependency of serverless-appsync-offline, need this resolved to run unit tests in our CI pipelines.