search

moscajs / mosca

MQTT broker as a module
mosca.io
3.2k stars 509 forks source link

there is new major version (2.0) of nodejs-redis => mosca is crashing #363

Closed ghost closed 8 years ago

ghost commented 8 years ago

after client connect

/opt/easyride/node_modules/mosca/node_modules/ascoltatori/lib/redis_ascoltatore.js:135 topic = topic.replace(new RegExp('/$'), ''); ^ TypeError: topic.replace is not a function

mcollina commented 8 years ago

The problem is within ascoltatori. Why don't you try to fix that?

ghost commented 8 years ago

Ok, boss. I will try.

ghost commented 8 years ago

https://github.com/mcollina/ascoltatori/pull/136

behrad commented 8 years ago

And as a proposal: Are you thinking @mcollina of switching to ioredis in new Mosca or Aedes redis persistence? Since thats a newer and more stable fork of node_redis

ghost commented 8 years ago

@behrad https://github.com/NodeRedis/node_redis/releases/tag/v.2.2.0

behrad commented 8 years ago

There's not performance issues, you can find there (in issues) that node_redis still have some stability problems, and some users of Kue have reported ioredis is more robust. Another important point is node_redis is not supporting Redis Cluster, which again ioredis does well. These are important requirements to mosca for improved redis backend support.

mcollina commented 8 years ago

If you want to send over PRs for migrating to ioredis, I'll merge them. Il giorno mer 14 ott 2015 alle 08:07 Behrad notifications@github.com ha scritto:

There's not performance issues, you can find there (in issues) that node_redis still have some stability problems, and some users of Kue have reported ioredis is more robust. Another important point is node_redis is not supporting Redis Cluster, which again ioredis does well. This are important requirements to mosca for improved redis backend support.

— Reply to this email directly or view it on GitHub https://github.com/mcollina/mosca/issues/363#issuecomment-147946616.

mcollina commented 8 years ago

Fixed in v1.0.0