search

moscajs / mosca

MQTT broker as a module
mosca.io
3.2k stars 508 forks source link

Bumped dependencies #589

Open mcollina opened 7 years ago

mcollina commented 7 years ago

Fixes #587

mcollina commented 7 years ago

cc @behrad would you like to have a look?

RobQuistNL commented 7 years ago

Please merge this. EDIT: Skipping tests because they break? Please dont merge this.

mcollina commented 7 years ago

@RobQuistNL LOL, thanks! :) So, would you like to help?

That feature is really not problematic and not MQTT related, but rather a problem in the actual tests.

This also depend on https://github.com/mcollina/ascoltatori/pull/168

wuhkuh commented 7 years ago

I'm working on fixing those tests you've skipped in this commit. This patch I'm working on will update dependencies, integration of standard, issue #541, and some minor tweaks. It might take a little bit longer before I've patched everything, because I have two busy weeks coming up. Doing a bit every day, though.

mcollina commented 7 years ago

@wuhkuh thank you so much. Keep up with the good work!

wuhkuh commented 7 years ago

@mcollina I'm back again, working on the patch. Exams are approaching so things tend to get slower as studying gets a higher priority now.

Anyway, on topic: As I've read in the MQTT.js notes: 2.x.x drops support for 0.12. I've checked your commit in this PR and you've updated mqtt version despite this incompatibility. Should mosca drop support for 0.12 or should I revert this change?

How realistic is 0.12 usage, by the way? It is EOL since 2016-12-31, so my personal preference is to drop this. I'm not in charge of these choices, though.

mcollina commented 7 years ago

This PR drops support for 0.12 as well.