Open eljefedelrodeodeljefe opened 7 years ago
Currently fails due to missing backend object in some cases. Gonna be on vacation during the week. If you like to drive this forward I am gonna fix it Friday.
I'm on vacation for the next two weeks myself.
Let's talk afterwards. Have a great time!
On Mon, 17 Apr 2017 at 02:06, Matteo Collina notifications@github.com wrote:
I'm on vacation for the next two weeks myself.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mcollina/mosca/pull/630#issuecomment-294381992, or mute the thread https://github.com/notifications/unsubscribe-auth/ADuBJEBotPnvqGIQdGAvWwlmia-tA6HTks5rwq0KgaJpZM4M-wUd .
-- Robert Lindstädt Berlin, Germany +49 176 701 904 78
CI is failing everywhere: https://travis-ci.org/mcollina/mosca/jobs/222653523#L1440.
Currently when you call the example redis implementations, I believe the options won't get passed through. You can easily miss this locally, as redis for example is just calling its defaults. However, setting password is silent fail.
The expectation from the redis example is that all options from the ascoltatore object gets passed down.
Though this fix fixed the redis problem I would maybe rather recommend modernisation around inheritance and option passing. But I know you know what best to do. I offer my help, as I am currently doing a lot with MQTT in a my day job.
Example: