mosdef-hub / foyer

A package for atom-typing as well as applying and disseminating forcefields
https://foyer.mosdef.org
MIT License
118 stars 77 forks source link

Migrate azure pipeline environment creation from conda to mamba #447

Closed justinGilmer closed 3 years ago

justinGilmer commented 3 years ago

PR Summary:

Previously, all conda environment creations use conda for the dependency resolution, which is notoriously slower than mamba's implementation.

This can have a noticeable impact on run times during CI as well as building docker images. Mamba has replaced conda in our dockerfile as well as our azurepipelines.yml file.

NOTE: mamba is not used for windows builds, due to previous issues attempting to use mamba.

PR Checklist


codecov[bot] commented 3 years ago

Codecov Report

Merging #447 (2e79bb2) into master (f4a7f88) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 2e79bb2 differs from pull request most recent head 5b951b6. Consider uploading reports for the commit 5b951b6 to get more accurate results

@@           Coverage Diff           @@
##           master     #447   +/-   ##
=======================================
  Coverage   73.84%   73.84%           
=======================================
  Files          17       17           
  Lines        1839     1839           
=======================================
  Hits         1358     1358           
  Misses        481      481