mosdef-hub / foyer

A package for atom-typing as well as applying and disseminating forcefields
https://foyer.mosdef.org
MIT License
117 stars 76 forks source link

Modify opls_validation ".top" impropers #506

Closed CalCraven closed 2 years ago

CalCraven commented 2 years ago

This PR aims to fix bugs in the opls_validation files. More specifically, improper parameters that were added to those files for testing do not using the correct "funct" value to designate them as periodic impropers. They had previously all been given the value of "1", which designates them as periodic propers. Parmed doesn't treat periodic propers any differently than periodic impropers, except to use a "dihedral.improper" boolean. They are still stored in structure.dihedrals.

This is relevant when doing conversion from a parmed object to GMSO, as GMSO has explicit container for impropers. This will be necessary when parameterizing in GMSO as opposed to ParmEd, and testing that the parameters are stored in this impropers container in GMSO.

See this link for more information about gromacs topology files. https://manual.gromacs.org/current/reference-manual/topologies/topology-file-formats.html

PR Summary:

PR Checklist


codecov[bot] commented 2 years ago

Codecov Report

Merging #506 (d3505d1) into main (24a5d5c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #506   +/-   ##
=======================================
  Coverage   73.68%   73.68%           
=======================================
  Files          17       17           
  Lines        1919     1919           
=======================================
  Hits         1414     1414           
  Misses        505      505