mosdef-hub / foyer

A package for atom-typing as well as applying and disseminating forcefields
https://foyer.mosdef.org
MIT License
117 stars 75 forks source link

Allowing automated atom typing for larger system(>=100 molecules) upon providing the exact coeff. for each atom,bond,angle,dihedral,impropers,etc. for it's smaller individual component( 1 molecule) .data file #569

Open amannsonii3 opened 3 weeks ago

amannsonii3 commented 3 weeks ago

Describe the behavior you would like added to Foyer A clear and concise description of what the proposed idea is.

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

amannsonii3 commented 3 weeks ago

I find foyer struggles with cyclic structures(I tried Ethylene Carbonate(EC) and Propylene Carbonate(PC)) more, than linear structures(dimethyl Carbonate(DMC) or ethyl methyl carbonate(EMC)) for atom typing. It finds multiple atom types for EC and PC, even though the exact parameters {Lucienne's param.} exist for PC specifically.

When I tried commenting on the confused atom types from the. XML forcefield file generates errors like the expected 17 bond angle parameters, but only 16 are found.

Since mBuild can easily build a box with the required molecules, I request a way to iterate over the molecules and assign them the parameter from what I supply for 1 such molecule. And expanding this to a system constituting different molecules. If one wants to use their own parameters, they can do so only after the foyer builds that file right and changes the .data file

But what if the foyer fails to build the .data file to begin with?

Pardon me if such a feature already exists, I just started out with research in MD(still an undergrad)