Closed CalCraven closed 6 months ago
I think this is already supported, likely need to change the default options and clarify the documentation for this method (https://github.com/mosdef-hub/gmso/blob/main/gmso/formats/json.py#L24-L42)
You're right. However, maybe we should make this clear at the topology.save()
documentation, because that's the standard way to write things out and it's easy to miss that only a partial topology was saved without the keyword.
Yes, totally support changing the default to True
(for saving out a typed structure)
This has been updated in the latest commit in https://github.com/mosdef-hub/gmso/pull/794
Addressed in #794
Seems like there's an issue saving the JSON state of a topology, where the parameters aren't stored at all. Maybe this is a good place to discuss if that's a feature we would want to have.
output