Closed chrisjonesBSU closed 8 months ago
Yes, I bumped into this issue too, and I think I had introduced a fix for it here https://github.com/mosdef-hub/mbuild/pull/1169/files#diff-3a5085d6be9766a5e783d6cc4745a042ee1939f2de22fc8e21bbd8600f1c1a87L13-L14. Sorry it was masked in a docs fix PR. Also, it's probably time for us to introduce python 3.12 to the test matrix.
Ok cool, thanks! Do we need to also pin the python version in the mbuild conda-forge feedstock, since that is where conda looks rather than the .yml
files in the repo.
Good point! I will update the conda-forge recipe to pin the python version when install from conda/mamba
FYI, I just checked our feedstock and the python versions have already been pinned there to be between 3.8 and 1.11
Ok yeah, I see that now. If I pull mbuild from conda-forge I get mbuild 0.17.0
and python 3.11. I think the problem is if I pull mbuild 0.16.4
from conda-forge, I get python 3.12, and the import errors. Is it possible to change previous version's dependencies on conda-forge? Using 0.17 fixes this, but I think I was having some issues building a mosdef environment packages were wanting python 3.12, so mbuild 0.16.4 was being used instead of 0.17. I think we can close this, but it might be worth checking if the python version can be changed for 0.16.4 as well.
I am not sure if we can update the python of past package (one solution I can think of is having a build, using the old sh256 and version number, but I am worry it may mess up the feed stock and the stack hosted on conda-forge). Would releasing mbuild 0.17.1 (so with the fix) sound appealing to you? I can try to have a release out tomorrow?
I don't think we need to do anything right now, I can't seem to re-create the issue anymore (where I was getting mbuild 0.16.4 instead of 0.17), and it sounds like this should be fixed for the latest release. Thanks!
Bug summary
If I create an anaconda environment that installs mbuild along with python 3.12, I get errors when trying to import mbuild.
Note, pinning python to 3.12 gives me
mbuild 0.16.4
If I pin python to 3.11, I getmbuild 0.17
. If I pin both mbuild=0.17 and python=3.12 then the packages are incompatibleCode to reproduce the behavior
Gives this error:
Software versions