Closed rsdefever closed 4 years ago
I think our soft import of babel is the cause here - it may take some updates to the import_
function to actually do from openbabel import openbabel
but it would be worthwhile
I am not sure this warning should be raised - it's all good and well that babel's conception of a "molecule" includes a box but this isn't so central to the design of a mbuild.Compound
that it absolutely must be a part of the conversion. And it seems like generating a babel molecule from a SMILES string doesn't usually include a box? I wonder if this warning is triggered 100% of the time. Other conversions from babel, if we want to use them, maybe should raise this warning.
There are a couple of warnings that get thrown when loading an
mbuild.Compound
from a SMILES string. E.g.,The two warnings are:
And:
The first appears to come from openbabel, but I don't quite understand why. I tried changing our import statement in utils/io.py from
import openbabel
tofrom openbabel import openbabel
, but the warning remains.The second looks like something in our
from_pybel
function in theCompound
class. Do we really need to be throwing a warning here? At least in the use case of creating compounds from SMILES strings this seems extraneous. I think this fits into further discussions we need to have about the role of abox
in anmbuild.Compound
.