mosdef-hub / mosdef-workflows

Sample molecular simulation workflows using a MoSDeF and community tools
13 stars 23 forks source link

Pore example #1

Closed rmatsum836 closed 4 years ago

rmatsum836 commented 5 years ago

Graphene slit pore example using the porebuilder recipe in mBuild. This working example plots the number density profile of water within the slit pore.

rmatsum836 commented 5 years ago

If I recall correctly, this is ready to be tested by another user.

ahy3nz commented 5 years ago

I like this example - it's a pretty sophisticated workflow and utilizes other packages like pore-builder and mtools.

But the notebook itself is complete and functional (I got it to run)

rmatsum836 commented 5 years ago

Thanks for running this and catching my dumb mistakes. Definitely weird about the results you're getting though, I'll check this.

rmatsum836 commented 5 years ago

So for some reason the dimensions used for the number density calculation were all wrong but it should be fixed now.

mattwthompson commented 5 years ago

soft requirement on https://github.com/rmatsum836/Pore-Builder/pull/18

My GROMACS build is borked on my macbook but I can try running the simulation tomorrow. But initial structure looks good.

rmatsum836 commented 5 years ago

Could someone retest this when they have a chance?

ahy3nz commented 5 years ago

Okay I ran the simulation in its entirety this time: image I'm not really worried about the simulation/analysis, but we should try to figure out something with these dependencies (mtools and porebuilder) #2

rmatsum836 commented 4 years ago

Thanks @uppittu11 for testing this out! I added some markdown cells and cleaned up the number density profile at the end of the notebook. If there are no other comments, I think this is ready to go.

mattwthompson commented 4 years ago

Looks nice to me, thanks for the contribution!