search

mosen / ccp-recipes

Autopkg recipes for Creative Cloud Packager workflows
Apache License 2.0
28 stars 2 forks source link

APPS_PANEL_ENABLED Setting is Lost #11

Closed foigus closed 7 years ago

foigus commented 7 years ago

When attempting to make a package with APPS_PANEL_ENABLED set to true, the setting is lost. Note this recipe fails for the issue noted in #9.

CreativeCloudDesktopAdminEnabled.munki Override

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>Identifier</key>
    <string>local.munki.CreativeCloudDesktopAdminEnabled</string>
    <key>Input</key>
    <dict>
        <key>ADMIN_PRIVILEGES_ENABLED</key>
        <true/>
        <key>APPS_PANEL_ENABLED</key>
        <true/>
        <key>BASE_VERSION</key>
        <string></string>
        <key>INCLUDE_UPDATES</key>
        <true/>
        <key>LICENSE_TYPE</key>
        <string>enterprise</string>
        <key>MUNKI_REPO_SUBDIR</key>
        <string>notbackedup/adobe</string>
        <key>NAME</key>
        <string>CreativeCloudDesktopAdminEnabled</string>
        <key>ORG_NAME</key>
        <string>Organization</string>
        <key>PRODUCT_ID</key>
        <string>KCCC</string>
        <key>RUM_ENABLED</key>
        <true/>
        <key>UPDATES_ENABLED</key>
        <true/>
        <key>VERSION</key>
        <string>latest</string>
        <key>pkginfo</key>
        <dict/>
    </dict>
    <key>ParentRecipe</key>
    <string>com.github.mosen.munki.Adobe.CreativeCloudApp</string>
    <key>ParentRecipeTrustInfo</key>
    <dict>
        <key>non_core_processors</key>
        <dict>
            <key>CreativeCloudFeed</key>
            <dict>
                <key>git_hash</key>
                <string>a274676a969e7e3815e767a3fd188dc687f61d48</string>
                <key>path</key>
                <string>/Users/admin/Library/AutoPkg/RecipeRepos/com.github.mosen.ccp-recipes/Adobe/CreativeCloudFeed.py</string>
                <key>sha256_hash</key>
                <string>af3e5f4a5350248ea7d4ec5ba2a2ae2f5b3fa992c803da4b4337541b5cbf3664</string>
            </dict>
            <key>CreativeCloudPackager</key>
            <dict>
                <key>git_hash</key>
                <string>276c62c6876977852dfc4ba3e10dac29959a8e03</string>
                <key>path</key>
                <string>/Users/admin/Library/AutoPkg/RecipeRepos/com.github.mosen.ccp-recipes/Adobe/CreativeCloudPackager.py</string>
                <key>sha256_hash</key>
                <string>fa6214ce5c59468c0f6466e5f91a65d929b0b47e3e1c8c92767df22c744605a2</string>
            </dict>
        </dict>
        <key>parent_recipes</key>
        <dict>
            <key>com.github.mosen.munki.Adobe.CreativeCloudApp</key>
            <dict>
                <key>git_hash</key>
                <string>1c5d1ebbc893d74af3d52db9b91cb426835d5fc0</string>
                <key>path</key>
                <string>/Users/admin/Library/AutoPkg/RecipeRepos/com.github.mosen.ccp-recipes/Adobe/CreativeCloudApp.munki.recipe</string>
                <key>sha256_hash</key>
                <string>7517ac61d6064804a77f56e1c250ee3c46d3d1e88d4446ae41dd14fb4875a352</string>
            </dict>
            <key>com.github.mosen.pkg.Adobe.CreativeCloudApp</key>
            <dict>
                <key>git_hash</key>
                <string>612780257ac22c117474241c19f1d4a6fb4cb5a8</string>
                <key>path</key>
                <string>/Users/admin/Library/AutoPkg/RecipeRepos/com.github.mosen.ccp-recipes/Adobe/CreativeCloudApp.pkg.recipe</string>
                <key>sha256_hash</key>
                <string>0919559156659fe374948d319ad3f47c6d77ee7ae2e7e8842efe61595c905dea</string>
            </dict>
        </dict>
    </dict>
</dict>
</plist>

autopkg run -vv CreativeCloudDesktopAdminEnabled.munki

$ autopkg run -vv CreativeCloudDesktopAdminEnabled.munki
Processing CreativeCloudDesktopAdminEnabled.munki...
CreativeCloudFeed
{'Input': {'base_version': u'', 'product_id': u'KCCC', 'version': u'latest'}}
CreativeCloudFeed: No value supplied for channels, setting default value of: ccm,sti
CreativeCloudFeed: No value supplied for platforms, setting default value of: osx10,osx10-64
CreativeCloudFeed: No value supplied for write_product_json, setting default value of: True
CreativeCloudFeed: No value supplied for fetch_release_notes, setting default value of: False
CreativeCloudFeed: No value supplied for fetch_icon, setting default value of: False
CreativeCloudFeed: No value supplied for parse_proxy_xml, setting default value of: False
CreativeCloudFeed: Fetching from feed URL: https://prod-rel-ffc-ccm.oobesaas.adobe.com/adobe-ffc-external/core/v4/products/all?payload=true&productType=Desktop&_type=json&channel=ccm&channel=sti&platform=osx10&platform=osx10-64
CreativeCloudFeed: Found matching product Creative Cloud, version: 3.9.5
CreativeCloudFeed: The feed version matches the last fetched version, no download is required
{'Output': {'display_name': u'Creative Cloud',
            'manifest_url': 'https://ccmdls.adobe.com/AdobeProducts/KCCC/1/osx10/manifest.xml',
            'version': u'3.9.5'}}
EndOfCheckPhase
{'Input': {}}
{'Output': {}}
CreativeCloudPackager
{'Input': {'admin_privileges_enabled': False,
           'apps_panel_enabled': False,
           'customer_type': u'enterprise',
           'device_pool_name': u'',
           'download_changed': False,
           'include_updates': True,
           'organization_name': u'Organization',
           'package_name': u'CreativeCloudDesktopAdminEnabled',
           'rum_enabled': True,
           'serial_number': u'',
           'updates_enabled': False}}
CreativeCloudPackager: No value supplied for language, setting default value of: en_US
CreativeCloudPackager: Found existing CCP package build automation info, comparing
CreativeCloudPackager: existing build: {
    "admin_privileges_enabled" = 0;
    "apps_panel_enabled" = 0;
    "customer_type" = enterprise;
    "download_changed" = 1;
    "include_updates" = 1;
    language = "en_US";
    "organization_name" = Organization;
    "package_name" = CreativeCloudDesktopAdminEnabled;
    products =     (
                {
            "sap_code" = KCCC;
            version = "3.9.5";
        }
    );
    "rum_enabled" = 1;
    "updates_enabled" = 0;
}
CreativeCloudPackager: current build: {'download_changed': False, 'package_name': u'CreativeCloudDesktopAdminEnabled', 'language': 'en_US', 'apps_panel_enabled': False, 'customer_type': u'enterprise', 'organization_name': u'Organization', 'admin_privileges_enabled': False, 'products': [{'version': u'3.9.5', 'sap_code': u'KCCC'}], 'include_updates': True, 'rum_enabled': True, 'updates_enabled': False}
CreativeCloudPackager: Executing CCP build command: /Applications/Utilities/Adobe Application Manager/core/Adobe Application Manager.app/Contents/MacOS/PDApp --appletID=CCP_UI --appletVersion=1.0 --workflow=ccp --automationMode=ccp_automation --pkgConfigFile=/Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/automation_xml/ccp_automation_CreativeCloudDesktopAdminEnabled.xml
CreativeCloudPackager: CCP Exited with status 0
{'Output': {'ccp_version': '1.11.0.34',
            'package_info_text': 'This package contains following updates\r\nAdobe Application Manager\r\n\r\n',
            'pkg_path': u'/Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled/Build/CreativeCloudDesktopAdminEnabled_Install.pkg',
            'uninstaller_pkg_path': u'/Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled/Build/CreativeCloudDesktopAdminEnabled_Uninstall.pkg'}}
DmgCreator
{'Input': {'dmg_path': u'/Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled_Install-3.9.5.dmg',
           'dmg_root': u'/Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled'}}
DmgCreator: Created dmg from /Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled at /Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled_Install-3.9.5.dmg
{'Output': {}}
DmgCreator
{'Input': {'dmg_path': u'/Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled_Uninstall-3.9.5.dmg',
           'dmg_root': u'/Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled/Build/CreativeCloudDesktopAdminEnabled_Uninstall.pkg'}}
creation of /Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled_Uninstall-3.9.5.dmg failed: hdiutil: create failed - No such file or directory

Failed.
Receipt written to /Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/receipts/CreativeCloudDesktopAdminEnabled-receipt-20170122-091114.plist

The following recipes failed:
    CreativeCloudDesktopAdminEnabled.munki
        Error in local.munki.CreativeCloudDesktopAdminEnabled: Processor: DmgCreator: Error: creation of /Users/admin/Library/AutoPkg/Cache/local.munki.CreativeCloudDesktopAdminEnabled/CreativeCloudDesktopAdminEnabled_Uninstall-3.9.5.dmg failed: hdiutil: create failed - No such file or directory

Nothing downloaded, packaged or imported.
timsutton commented 7 years ago

There are quite a few settings for the package customization which aren't currently being "passed through" to the actual packaging processor.

Since I've been hinting at this for quite a while without having written any code, I'm going to propose in a separate issue (probably today) how I think the Input for the Adobe CCP Package recipes could be modified so that we can more easily deal with the many different settings which are possible to override. This change would address this issue as well as #6, #8, and #10.

benmartel commented 7 years ago

I assume it works if you just check the setting really quick? I have those settings enabled. I just don't get any errors when running though. I tried enabling those settings really quick but it the resulting package seems to be bad.

mosen commented 7 years ago

This will be a part of the upcoming branch feature/ccpinfo when its finished, just FYI.

timsutton commented 7 years ago

This is now supported as the appsPanelEnabled key in the ccpinfo dict.