search

mosen / puppet-cups

puppet module for the CUPS printing system
36 stars 33 forks source link

Doesn't manage Service[cups]??? #42

Open jflorian opened 9 years ago

jflorian commented 9 years ago

After ditching my old cups module in puppet for yours everything seemed to be running smooth. However, upon building a new host I was surprised to see this kind of error:

Error: /Stage[main]/Local::Subsys::Cups/Printer[brother-guten]: Could not evaluate: Execution of '/usr/sbin/lpadmin -x brother-guten' returned 1: lpadmin: Unable to connect to server: Bad file descriptor

I traced this to the fact that the cups service wasn't running. Shouldn't your module be managing that as well?

mosen commented 9 years ago

Hi there, sorry for the late reply.

I accepted a pull request for managing the service by including the 'cups' manifest, but as yet haven't added testing for that feature. If you include 'cups' does it not ensure the service is running?

octomike commented 8 years ago

We have the same problem.

I think the reason for us is that cups' upstart script on ubuntu takes ages to run while "service cups status" returns 0 (with a note that it is in stage post-start) so puppet thinks it's all good to go. But when the module tries to add printers the socket in /var/run is not yet up.

Should we create a custom status script that blocks/waits for a while?

mosen commented 8 years ago

Hey there. I haven't tested against upstart (I'm not using puppet-cups much these days) but I'm happy to test in a VM and see why the service fails.