search

moses-palmer / pystray

GNU General Public License v3.0
473 stars 59 forks source link

Notification cannot be set to automatically disappear #84

Closed anaselli closed 3 years ago

anaselli commented 3 years ago

According to notify we need to explicitally hide it after rising, there is no auto hiding.

https://github.com/moses-palmer/pystray/blob/ccc699d32298ac7198664bd9a7afde7bbbccb577/lib/pystray/_util/notify_dbus.py#L84

Following the dnfdragora issue I wonder if we could have a way to make it working following default desktop setting for notification hiding. Is there a chance to have -1 instead, maybe not as default behavior by changing some properties?

moses-palmer commented 3 years ago

Thank you for your report and suggestion.

I have updated the master branch to use -1 instead of 0, as that is a more reasonable default.

anaselli commented 3 years ago

Great thanks!

Woi commented 3 years ago

@moses-palmer What is the plan for a release including this bugfix? While it's technical a trivial patch, its impact is very visible to users. With a new release of pystray, distribution maintainers could easily build new packages and relief many users of this daily annoyance.

moses-palmer commented 3 years ago

@Woi, I have released pystray 0.17.3 which includes this fix.

Woi commented 3 years ago

@moses-palmer Thanks a lot