search

moses-smt / mosesdecoder

Moses, the machine translation system
http://www.statmt.org/moses
GNU Lesser General Public License v2.1
1.58k stars 775 forks source link

Placeholders should be separated by comma #188

Closed lonevvolf closed 6 years ago

lonevvolf commented 6 years ago

According to the documentation at http://www.statmt.org/moses/?n=Advanced.Hybrid#ntoc4 when passing multiple placeholders to the extract command, it looks like they should be separated by a space. The actual code, however, expects them to be comma separated. Most likely the documentation should be updated to reflect this.

hieuhoang commented 6 years ago

Hiya. Thanks for reporting this. I can't see where I should change it or make it clearer. Tell me what you think I should change and I'll get on the case.

lonevvolf commented 6 years ago

I would suggest adding a comment after the extract command example, simply stating: "When passing multiple placeholders to the extract command, separate them with a comma (,)."

On Fri, Dec 22, 2017 at 2:24 PM, Hieu Hoang notifications@github.com wrote:

Hiya. Thanks for reporting this. I can't see where I should change it or make it clearer. Tell me what you think I should change and I'll get on the case.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/moses-smt/mosesdecoder/issues/188#issuecomment-353597849, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXZ7Trgos_W5dzuhjilEJRx_c5Pq3gaks5tC62bgaJpZM4RIUxq .

hieuhoang commented 6 years ago

cheers, done

hieuhoang commented 6 years ago

closing unless you have other issues with it