search

moses-smt / mosesdecoder

Moses, the machine translation system
http://www.statmt.org/moses
GNU Lesser General Public License v2.1
1.58k stars 778 forks source link

The dot before an acronym should be optional. #212

Closed alvations closed 5 years ago

alvations commented 5 years ago

Within the non-breaking prefixes when checking for acronyms, it's checking whether:

  1. the first character of an acronym is a dot
  2. the token is made of all caps or dashes
  3. the acronym ends with one or more dots

Criterion (1) for acronymn check is weird, most acronym shouldn't have a dot before and most probably that makes this elsif un-used most of the time.

Instead the pre-caps dot could have been made optional, as proposed in the changes.

hieuhoang commented 5 years ago

cheers