mosesliao / fastlane-plugin-lizard

🦎Official fastlane plugin for lizard code complexity analytics 🦎
http://www.lizard.ws/
MIT License
28 stars 13 forks source link

Lizard exclude parameter being generated incorrectly by the plugin #41

Closed Unknoob closed 4 years ago

Unknoob commented 4 years ago

I tried to set a exclude parameter with multiple patterns but the plugin is incorrectly generating the command so lizard ignores the patterns.

Here's the plugin call on fastlane

lizard(
      source_folder: ".", 
      exclude: "./Folder1/Subfolder1/*, ./Folder2/*",
      language: "swift", 
      export_type: "xml", 
      report_file: "sonar-reports/lizard-report.xml"
    )

The command generated is: lizard -l swift --xml -x ./Folder1/Subfolder1/* -x ./Folder2/* . > sonar-reports/lizard-report.xml

But according to lizard documentation it should be: lizard -l swift --xml -x "./Folder1/Subfolder1/*" -x "./Folder2/*": . > sonar-reports/lizard-report.xml

Reference: https://github.com/terryyin/lizard/blob/master/README.rst Don't forget to add "" around the pattern.

mosesliao commented 4 years ago

@Unknoob thank you for your contribution. I have approved and merged your fix.

You are now added as a collaborator for this plugin. Once again thank you