Fix issues with lizard executable logic

[mgrebenets]

• Lizard executable expects the following:
  • lizard [options] [PATH or FILE] [PATH] ...
  • But current code puts PATH (source_directory) before the options
• The check for 'which lizard' ignores 'params[:executable]' option

[mgrebenets]

@liaogz82 can't figure out how to add reviewers, so pinging you instead 👍

[mosesliao]

Give me some time to check the CI review. thanks

[mosesliao]

wait... you are PRing from your own fork. The CircleCI is not running because of that.

let me google for solutions to the CI problem. May take a bit longer. Please don't remove the fork for now

[mgrebenets]

Hm... interesting, I've been using forks before on other open-source repos. It should have picked it up, the changes are on my fork, but the PR is on main repo.

[mosesliao]

Could you try add a comment and do a git push -f or something? thanks.

it is a circleCI setting. it was off just now

[mosesliao]

ok running

[mgrebenets]

Good point on CI part, I'll check if I can add any specs for this change.

[mosesliao]

oh btw, the rake release will be done manually once the bug get solved.

[mosesliao]

https://circleci.com/gh/liaogz82/fastlane-plugin-lizard/25

strange. it is passing here.

[mgrebenets]

Strange indeed, because I definitely broke the test that checks the order of input folder and -l swift option 🤔

I've just pushed updates with new rspecs and fixed rspec for position of source folder.

[mgrebenets]

Wow, that's fast, but this CI run was using new tests:

    when specify custom executable
      uses custom executable
      should raise if custom executable does not exist <-- this one's new

[mgrebenets]

@liaogz82 Sounds good to me. Thanks 🎉