mosh-hamedani / vidly-api-node

309 stars 282 forks source link

Increased auth performance #13

Open goto3 opened 5 years ago

goto3 commented 5 years ago

Hello, I am a starting with node.js and I found something interesting:

On auth file in routes folder I changed this on line 17:

const validPassword = await bcrypt.compare(req.body.password, user.password);
if (!validPassword) return res.status(400).send("Invalid email or password.");

image

to this:

await bcrypt.compare(req.body.password, user.password, function(err, result) {
    if (!result) return res.status(400).send("Invalid email or password.");
});

image

and decreased request processing time from 85 ms to 5 ms average.

Why is that?

Note: I am using bcrypt v3.0.6

Thank you very much

rustemjantayev commented 5 years ago

Because the request was cached. Try run different users ,and you will see.