search

mosharaf13 / fleet-searcher

Upload a CSV file containing keywords and view google search stats
2 stars 0 forks source link

Start of the code review process 👋 #30

Open olivierobert opened 1 year ago

olivierobert commented 1 year ago

Hello Mosharaf 👋 , thank you for your effort on the code submission. I am Olivier at Nimble and am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, and thus I will create issues where there could be more improvements regarding your performance here.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. So that you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇

We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need additional time, please let us know as soon as possible so we can plan accordingly.

In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘

olivierobert commented 1 year ago

I have completed the first round of code reviews. I am looking forward to your feedback on all open issued.

mosharaf13 commented 1 year ago

Hi,

Thank you for your feedback on my code. I appreciate your thorough review and suggestions for improvement. I had fun completing the coding challenge and I will try to address the issues as soon as possible. However, I have some pre-planned sessions during the afternoons (3pm to 7pm BD time) that may impact my availability.

To ensure that the review process stays on track, I will prioritize the issues that take shorter time to implement first and work on closing them as soon as possible. I will make sure to communicate with you regularly and keep you informed of my progress.

Once again, thank you for your time and effort in reviewing my code. I am looking forward to working with you to make the necessary improvements.