search

mosharaf13 / fleet-searcher

Upload a CSV file containing keywords and view google search stats
1 stars 0 forks source link

[Chore] Split VueJS components #32

Closed olivierobert closed 1 year ago

olivierobert commented 1 year ago

Issue

https://github.com/mosharaf13/fleet-searcher/blob/main/resources/js/components/FleetSearch.vue is a God component as it contains all rendering and presentation logic for the main application. This makes it easy to read and maintain.

Expected

Extract and separate each UI module into its distinct component.

image

Note Comunication between components can be achieved with $emit (see docs)

mosharaf13 commented 1 year ago

Yes, splitting the FleetSearch Component into separate components is a chore 😄 that should be regularly performed to make sure my components doesn't become bloated.

I am planning to split it into three separate components as you suggested. Once I am complete I will create the pull request.