mosharaf13 / fleet-searcher

Upload a CSV file containing keywords and view google search stats
2 stars 0 forks source link

Render stored raw response in ui to let user view their keyword search response from google #39

Open mosharaf13 opened 1 year ago

mosharaf13 commented 1 year ago

Resolves #35

The user can now view raw response from google. The rendered page of google currently has some bugs listed below.

I have attached screenshots for your better understanding.

To debug these issues I need more time. If you could let me know, what's specific targets we are trying to achieve on this page that would be really helpful for me to estimate the duration for the completion of this feature.

Thanks for designing this problem. I had fun solving it. Learned some new things about google search page.

js_not_defined css_breakdown

olivierobert commented 1 year ago

How use an iframe instead and add the HTML content via the attribute srcdoc? While iframes are not usually the best method to render content, they do seem to be the best approach to isolate the scraped content from the host application.

mosharaf13 commented 1 year ago

I did the feature with an iframe first. Then I thought users might have pop up blocker installed in their browsers. So, I reverted back to showing the rendered scrapped content in a separate page. In terms of UX, I am wondering if using a modal would be a better option than these two. User won't have to go to different tab to view the page, and there's no possibility of any third party extension blocking the view of the modal. What's your thoughts on that? Should we go for iframes? or should we show the scrapped content in a modal?