moshekaplan / palo_alto_firewall_analyzer

Python scripts for reviewing Palo Alto Firewall configurations
Creative Commons Zero v1.0 Universal
25 stars 8 forks source link

Data segmentation in JSON file #81

Open Nawtest opened 6 months ago

Nawtest commented 6 months ago

Hello, I have added the 'Detail' block to the JSON file to separate, as much as possible, the data in the report. Additionally, I have modified the returns by adding a count with the number of validations performed to calculate KPIs.

Here examples:

image

image

image

Nawtest commented 5 months ago

I remove the check of output-format = None, and fixed problem with function parsed to json

moshekaplan commented 5 months ago

Would you be able to resolve the conflicts so I can review it for merging?

Nawtest commented 5 months ago

Hi, I've resolved the conflicts but logically, due to having made structural changes, the tests are failing. I'm reviewing them and adding the correct returns.