search

moshen / jekyll-asset_bundler

A small plugin for Jekyll to easily bundle and compress site assets
MIT License
101 stars 21 forks source link

dev mode when serving #24

Open avillafiorita opened 10 years ago

avillafiorita commented 10 years ago

I'm not sure whether it is a bug or a feature... but "watching" or "serving" sets "dev" to true, regardless of any declaration of "dev" in _config.yml.

It seems to me that a more reasonable behavior would be that of respecting any declaration of "dev" in _config.yml and automatically set "dev" to true when serving or watching only when there is no "dev" key defined in _config.yml.

The more general issue I'm facing is being able to test a site with the minified javascripts and css before deploying it.

moshen commented 9 years ago

That is the intended behavior, but I like your "more reasonable" approach. The problem is the way Jekyll regenerates the site. If you make a change to a css file included in a bundle, the new bundle name and contents will not be (currently) generated and placed in the _site folder.

vascoalexander commented 9 years ago

This behaviour makes the plugin useless (without source code modification), in an environment where jekyll runs as hosted application,.serving the files. In my case that's redhat's app hosting platform: openshift.

I understand the conflict with jekylls site regeneration, but i think the configuration option shouldn't be overwritten. In that way its in the hand of the user to apply the correct config for his environment and needs. For me it works by deleting the relevant lines of code, but i would prefer configuration over src code modification.