Closed berkes closed 11 years ago
Mac/Linux/Windows?
Could you post the bundle source from your template/html file?
Here is the source with a few lines of context:
<link rel="author" href="{{ BASE_PATH }}/humans.txt" type="text/plain" />
{% bundle %}
- /assets/javascripts/app.js
- /assets/stylesheets/app.css
{% endbundle %}
<!-- Included CSS Files -->
<link rel="stylesheet" href="{{ ASSET_PATH }}/stylesheets/foundation.css">
I have tried changing indentation, tried the one-line version and tried adding a ---
to the top of the block.
Machine is Linux, Ubuntu 12.10, RVM used to manage ruby.
It could very well be a version issue. I just checked my version and I'm currently running:
I will put in a check and post a fixed version for you to test.
I found the issue. It is indeed the difference between liquid versions:
In version 2.2.2:
render
returns an array
In version 2.4.0:
render
returns a string (by joining the results of the .each
call)
I'm pretty sure this was a bugfix on their part, because when you look at the root Tag
class here, it returns a string from the render
method stub.
I will still put in a check, but you may want to upgrade if you find incompatibilities with other plugins.
Problem with upgrading is that Gihub's Jekyll-parser uses 2.2.2, so upgrading means leaving the github-post-push building and doing it offline.
I'm not sure I understand. GitHub uses the safe option, which means you can't use any custom plugins with GitHub pages and Jekyll.
Ah, I was not even aware of that flag :(. That pulls the moment to start compiling my own drastically forward :)
Upgrading Liquid to 2.4.x indeed works.
Glad to know that it works. Finding out about the "safe" usage led me to writing my own Jekyll plugins. If you have your own host, it's pretty easy to make a git post-receive hook that rebuilds your site for you to replicate the GitHub workflow. I went the other way and have my jekyll site Rakefile build and rsync the results to the remote.
Probably a version issue.
When running jekyll with this plugin and a bundle, or bundle_glob-tag, the following error is returned:
It seems that BundleTag::render, after calling Super gets an array, not a String.
My versions are: jekyll (0.11.0) liquid (2.2.2) ruby 1.9.3p286 YAML::ENGINE.yamler #=> "psych"