Bump `request` per security warning

moshen / node-googlemaps

A simple way to query the Google Maps API from Node.js

MIT License

559 stars 148 forks source link

Bump `request` per security warning #122

Closed kirkstrobeck closed 7 years ago

kirkstrobeck commented 8 years ago

Request is now https://github.com/request/request/tree/v2.73.0
Vulnerability https://nodesecurity.io/advisories/77 Path: googlemaps@1.6.0 > request@2.44.0 > hawk@1.1.1

fabriziomoscon commented 8 years ago

Hi @kirkstrobeck thanks for contributing. Could you rebase your code in top of master and run the testa again?

kirkstrobeck commented 8 years ago

master is currently failing

fabriziomoscon commented 8 years ago

yes sorry my bad. It should be fine again now

fabriziomoscon commented 8 years ago

I don't get what happened here. It seems that you merged master rather than rebase your branch in top of it. Maybe it would be faster to branch from the upstream/master and re-submit the PR.

fabriziomoscon commented 7 years ago

published as npm googlemaps@1.12.0