moshen / node-googlemaps

A simple way to query the Google Maps API from Node.js
MIT License
559 stars 148 forks source link

Maximum URL size #138

Open PedroFabrino opened 7 years ago

PedroFabrino commented 7 years ago

According to Google's documentation for Static Map, the max size for url is 8192 characters, https://developers.google.com/maps/documentation/static-maps/intro#url-size-restriction.

But, when building an static map with gm.staticMap(params), I get the following error: Error: Request too long for google to handle (2048 characters). at module.exports (.../node_modules/googlemaps/lib/utils/makeRequest.js:63:13) at module.exports [as staticMap] (.../node_modules/googlemaps/lib/staticMap.js:116:10)

It's thrown an error before making a request for google, so it's internal.

Could it be fixed? Or should I make a fork for doing so? Or is there a reason as not working?

ClaaziX commented 7 years ago

if there are only 2045 chars and the lmit is 8192... why is it throwing this error at all?

PedroFabrino commented 7 years ago

Because the error is being thrown by the node-googlemaps, and not by google itself.

jitendra-kr commented 7 years ago

Yes i am facing same problem. I created an issue also for the same.

twindual commented 4 years ago

In the /lib/requests/contants.json file it has the max values listed as 2048.

We could up that to 8192 and solve the issue.

"MAX_REQUEST_LENGTHS": { "directions": 2048, "distance-matrix": 2048, "elevation": -1, "geocode": 2048, "place-details": 2048, "place-search-nearby": 2048, "place-search-text": 2048, "place-autocomplete": 2048, "reverse-geocode": 2048, "static-map": 2048, "timezone": 2048, "street-view": 2048 },