search

moshen / node-googlemaps

A simple way to query the Google Maps API from Node.js
MIT License
559 stars 148 forks source link

add departure_time and arrival_time to direction API #43

Closed fabriziomoscon closed 10 years ago

fabriziomoscon commented 10 years ago

In case of travel_mode transit we need to specify either arrival_time or departure_time. Penalty INVALID_REQUEST from google.

fabriziomoscon commented 10 years ago

@moshen is there any reason not to merge this PR ?

bockmabe commented 10 years ago

+1, this addresses issues for me as well.

fabriziomoscon commented 10 years ago

@bockmabe I have added an Error in case the API user doesn't provider arrivalTime or departureTime ONLY when mode is transit I have also added 2 test cases to prove the new code works, and bumped the version in package.json to 0.1.10 so this is ready to get merged by @moshen

fabriziomoscon commented 10 years ago

@regality are you maintaining this repo? Is there anybody merging pull requests?