search

moshen / node-googlemaps

A simple way to query the Google Maps API from Node.js
MIT License
559 stars 148 forks source link

allows for method geocode to ingest an object #65

Closed ffflabs closed 9 years ago

ffflabs commented 9 years ago

allows to call the geocode method as

gm.geocode({address: "444 Castro Street", region:"US", language:"EN"}, callback);

instead of 

gm.geocode("444 Castro Street", callback, false, null, "US", "EN");

why? two reasons:

fabriziomoscon commented 9 years ago

Agreed! This change and other are currently dealt with in this github issue and branch: https://github.com/moshen/node-googlemaps/issues/51

Please feel free to review and contribute for the new lib version

ffflabs commented 9 years ago

@fabriziomoscon I don't quite understand the Travis failure. It seems to have choken on npm install eyes but I haven't messed with package.json.

fabriziomoscon commented 9 years ago

hey don't worry about that... it was a network failure while TravisCI was fetching repos from npm. it says it re-tried 3 times then it gave up. This was only for node 0.8, whereas 0.10 and 0.11 passed. There is no options to re-run the build, I guess because open source projects use the free tier.

I won't merge this Pull request though, because this changes are going to be in version 1.0.0 If you want to use your changes on your projects just specify that in your package.json like so:

"googlemaps": "git://github.com/amenadiel/node-googlemaps.git"
ffflabs commented 9 years ago

Does it mean that you will include this PR later, or that I should create another PR, or that you already had this changes in place for the next version, so this PR is not needed anymore?

fabriziomoscon commented 9 years ago

I won't merge this into master since this change is already in the new version: https://github.com/moshen/node-googlemaps/blob/new-major-version/lib/geocode.js

but you can still use your fork without waiting for the new version under npm or even use the new version's library:

"googlemaps": "git://github.com/moshen/node-googlemaps.git#new-major-version"

so you should close this PR...