moshest / next-client-cookies

SSR and client support for cookies in Next.js 13 (app directory)
MIT License
136 stars 9 forks source link

Fix MJS issues #20

Closed ysulyma closed 3 months ago

ysulyma commented 3 months ago

Thanks for the library. This PR fixes ~two~ three issues I was encountering:

Your original code was working for me at one point, so I don't know why it suddenly started breaking, and I wasn't able to put together a minimal repro. These are all how ESM is supposed to work though.

moshest commented 3 months ago

I'm not sure what's wrong in your setup. It usually common to import from "next/navigation" and not from "next/navigation.js" so I can't approve this PR. Same apply for the esbuild rewrite script.

Happy to approve the export type * fix for the types.ts file.