search

moshfeu / vscode-compare-folders

The source code of the extension CompareFolders
https://marketplace.visualstudio.com/items?itemName=moshfeu.compare-folders
MIT License
116 stars 17 forks source link

[error] Maximum call stack size exceeded #174

Open davidbien opened 2 days ago

davidbien commented 2 days ago

Original message: Oops, something went wrong while comparing

System Info Editor version: 1.95.3 Extension version: 0.25.1 OS: darwin 24.0.0

Stack RangeError: Maximum call stack size exceeded at String.match () at readBufferedLines (/Users/davidbien/.vscode/extensions/moshfeu.compare-folders-0.25.1/node_modules/dir-compare/build/src/FileCompareHandler/lines/lineReader/readBufferedLines.js:23:49) at /Users/davidbien/.vscode/extensions/moshfeu.compare-folders-0.25.1/node_modules/dir-compare/build/src/FileCompareHandler/lines/lineBasedCompareAsync.js:69:58 at Generator.next () at fulfilled (/Users/davidbien/.vscode/extensions/moshfeu.compare-folders-0.25.1/node_modules/dir-compare/build/src/FileCompareHandler/lines/lineBasedCompareAsync.js:5:58)

moshfeu commented 1 day ago

Hi, thank you for reporting

Can you tell if there are a special files in the folders? Links? Very large files?

davidbien commented 1 day ago

yeah there are a ton of directories and files etc - i use vcpkg and some very large libraries you may want to consider a non-recursive algorithm - ie. a stack etc - i haven’t looked at your code but this is my guess

Get Outlook for iOShttps://aka.ms/o0ukef

From: Mosh Feu @.> Sent: Saturday, November 23, 2024 9:59:17 PM To: moshfeu/vscode-compare-folders @.> Cc: David L. Bien @.>; Author @.> Subject: Re: [moshfeu/vscode-compare-folders] [error] Maximum call stack size exceeded (Issue #174)

Hi, thank you for reporting

Can you tell if there are a special files in the folders? Links? Very large files?

— Reply to this email directly, view it on GitHubhttps://github.com/moshfeu/vscode-compare-folders/issues/174#issuecomment-2495814684, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKSVVVDOYVCAKUSVJTSHMFL2CFMKLAVCNFSM6AAAAABSLNXYI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJVHAYTINRYGQ. You are receiving this because you authored the thread.Message ID: @.***>