search

mosip / inji-wallet

MIT License
17 stars 81 forks source link

Error pops up "Flight mode must be disabled for the scanning functionality", even if the device is not in flight mode #145

Closed Anushree09-N closed 1 year ago

Anushree09-N commented 1 year ago

Describe the bug Error pops up "Flight mode must be disabled for the scanning functionality", even if the device is not in flight mode.

To Reproduce

  1. Unlock the app using passcode / biometrics
  2. Go to SCAN (second icon from left).

Current behavior Displayed error message "Flight mode must be disabled for the scanning functionality", even if the device is not in flight mode".

Expected behavior As flight mode is already disabled on the device it shouldn't display error message and scanner should be opened for scanning functionality.

Screenshots IMG_0032

Smartphone (please complete the following information):

Sujithbn commented 1 year ago

@Anushree09-N: Please verify and update the bug

Anushree09-N commented 1 year ago

@Sujithbn The issue is resolved now but we would like to know the fix given.

Sujithbn commented 1 year ago

This issue has been taken care by Newlogic team.

Sujithbn commented 1 year ago

Please verify once and close it.

Sujithbn commented 1 year ago

@kyanthony We would like to know the root cause of the issue, please update the details and assign it back to Anushree.

pmigueld commented 1 year ago

This issue was already fixed by removing the unnecessary check to flight mode: https://github.com/mosip/inji/issues/74

cc: @kyanthony

pmigueld commented 1 year ago

@Sujithbn @rakhimosip as stated above this has been fixed already and is ready for testing.

Sujithbn commented 1 year ago

@pmigueld We wanted to know the root cause of the issue, post which we can close this bug

pmigueld commented 1 year ago

@Sujithbn Flight mode check was added in an attempt to resolve ticket: idpass#103

Some time later the flight mode check was causing a bug so we investigated why we had this in the first place and figured it was unnecessary so it was removed here: https://github.com/mosip/inji/issues/74#issuecomment-1308312874

Since it is no longer used other issues involving the flight mode check should be resolved.

Anushree09-N commented 1 year ago

Verified in :

iPhone 11 iOS version 15 BLE 5.0 Commit id of the app: 4c2ca4b APK link: https://github.com/mosip/inji/actions/runs/4447486079

https://user-images.githubusercontent.com/79500509/226613886-80a6ad6e-70fd-486a-bd57-f031ead0b3cd.mp4

Able to open scanner when flight mode is disabled , working as expected.