search

mosip / inji-wallet

MIT License
24 stars 83 forks source link

Inji app crashing while sharing #276

Closed santhoshsunder closed 1 year ago

santhoshsunder commented 1 year ago

Describe the bug The Inji app is crashing while sharing the VC

To Reproduce prerequisite : Device A --> Requesting Device B --> Sharing

Open qrcode in Device A Open scanner in Device B Scan the qrcode from Device B

Observed result The Device B's app is crashing, after the scan is completed

Expected behavior The connection should be established, and should able to perform VC sharing

Screenshots https://user-images.githubusercontent.com/102220709/203906781-5deb20fc-e78a-499d-9f50-31b3352c7267.mp4

Smartphone (please complete the following information):

srikanth716 commented 1 year ago

We have found that the issue is from SingleVcItem.tsx file, It is looping in the same state (reviewing.selectingVc) in the scan.ts file. It is showing " Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops " in the terminal logs.

santhoshsunder commented 1 year ago

Summarry : When the photo is captured without a face and if we are trying to authenticate it the app is crashing.

Steps to reproduce : prerequisite : Device A --> Requesting Device B --> Sharing

  1. Open qrcode in Device A
  2. Open scanner in Device B
  3. Scan the qrcode from Device B
  4. In the sharing ID screen in device B, select the UIN card you want share
  5. And click on the "Accept request and verify" button
  6. When the camera is opened, capture something else without containg a human face

Observed : The app is authenticating the photo and the whole app is crashing

Screenshot : https://user-images.githubusercontent.com/102220709/205267664-28241e8a-0d1c-4a39-9e45-bde2050147ff.mp4

pmigueld commented 1 year ago

When the camera is opened, capture something else without containg a human face

This is an issue with the face-matching SDK (0.1.1). It crashes when no faces are found:

image

See here: https://github.com/mosip/mosip-mobileid-sdk/blob/InjiFaceSdk/android/src/main/java/com/mosipinjifacesdk/MosipInjiFaceSdkModule.java#L104

cc: @MonobikashDas @jannahadlaon

santhoshsunder commented 1 year ago

The app is still crashing after the VC is shared and opened in detailed view from the android side, we have raised three bugs according to this issue iam attaching them both bellow

Additional context https://github.com/mosip/inji/issues/319 https://github.com/mosip/inji/issues/321 https://github.com/mosip/inji/issues/322

Anushree09-N commented 1 year ago

Tested in qa5 env, 1.2.0.1 , App crashing issue is resolved which was associated with scanning functionality sharing is working. Device: iPhone 8 & iPhone 11 OS: 16.0.2 (20A380), 15.6.1 Inji app version: 0.4.1 (5) -> Testflight MOSIP Version: 1.2.0.1 MOSIP server: qa5.mosip.net

santhoshsunder commented 1 year ago

Tested in qa5 env, 1.2.0.1 , App crashing issue is resolved which was associated with scanning functionality sharing is working. hense closing this bug

screenshot: https://user-images.githubusercontent.com/102220709/206678159-c66d1c55-0619-4282-90be-ee0efd4745bf.mp4

Smartphone :