search

mosip / inji-wallet

MIT License
24 stars 83 forks source link

Android - app size is very big #354

Closed santhoshsunder closed 11 months ago

santhoshsunder commented 1 year ago

Describe the bug The app size is very big, even if it has two credentials downloaded the app crossing 150 mb

Expected behavior The app size should be small as possible, so that it would be usable by lot more people

Observed before install the app is 94 MB, once the app is installed, its getting extracted upto 144 MB, after two credentials downloaded the app got to 168 MB

Screenshots image

Smartphone : Device: PIXEL 6 OS: Android 13 MOSIP Version: 1.2.0.1 MOSIP server: qa5.mosip.net APP link; https://mosip.atlassian.net/browse/DSD-1816

Sujithbn commented 1 year ago

This issue not target for Beta release

Sujithbn commented 1 year ago

@kyanthony Please review and share your thoughts.

kyanthony commented 1 year ago

@rakhimosip what would the target acceptable size ?

rakhimosip commented 1 year ago

@kyanthony we will need to consider a couple of parameters while arriving at the optimal size. One is that we should be able to publish the app on Google play store and Apple store. There may be size limitations here. Second, it should also run on low-end smartphones that don't have large memory. @MonobikashDas please add your thoughts here.

pmigueld commented 1 year ago

The build now separates per architecture and the size has been reduced to around ~80mb installed. Downloading VCs add up to around ~200kb user data (including metadata) based on sampls in collab instance.

Tested on:

MonobikashDas commented 1 year ago

Please see above comment from paolo for root cause and fix.

santhoshsunder commented 1 year ago

@gsasikumar the size of the app in the current build is 149 mb (before it is installed), then once we install the app. it is extracted to 234 mb (without any user data, just as a fresh install), I am attaching the build details and the size details screenshots below, please provide your inputs.

Screenshot : APK size before install image

APK size just after install, without any user data image

Smartphone : device : redmi k20 pro ble : 5.0 android : 11 MOSIP Version : 1.2.0.1 MOSIP server : qa-1201-b2.net APP link : https://github.com/mosip/inji/actions/runs/4447486079

gsasikumar commented 1 year ago

We need to reduce the size of the app to less than 100 MB. Smaller the size easier for people to use it.

Pragya279 commented 1 year ago

This bug has been moved to Jira. Link to Jira bug: https://mosip.atlassian.net/browse/MOSIP-26838

ravikp commented 1 year ago

After discussing with @gsasikumar, we are moving this out of hotfix release.

santhoshsunder commented 11 months ago

verified as fixed in the build with commit id in the below screenshot. https://drive.google.com/file/d/15uWjasH2tRj0qCau8Ljj8YFEoSXi6mfd/view?usp=drivesdk