mosip / inji-wallet

MIT License
19 stars 83 forks source link

Update the labels for buttons to "Share" and "Share with Selfie" in credential share screen #589

Closed nayakrounak closed 1 year ago

nayakrounak commented 1 year ago

Describe the bug The labels in the credential share screen need to be modified.

Pre-requisite The application should have at least one credential to share.

To Reproduce Steps to reproduce the behaviour:

  1. Open the application
  2. Click on the QR code scanner
  3. Scan the verifier QR code to connect with the verifier application
  4. Share credential screen is shown below

Expected behaviour The labels for sharing credentials buttons need to be modified.

Screenshots

image

Smartphone (please complete the following information):

Not Applicable

Additional context Enhancement as discussed with Sasi on 24th Feb 2023.

PuBHARGAVI commented 1 year ago

Labels are changed to "share" and "share with Selfie" in english language. Translation for other languages required apart from english

ravikp commented 1 year ago

Issue merged in the PR - https://github.com/mosip/inji/pull/595

Alka1703 commented 1 year ago

The following PRs implements text change on the button labels on the consent page:

PR for mosip/tuvali: #28 PR for mosip/inji: https://github.com/mosip/inji/pull/595, https://github.com/mosip/inji/pull/597

The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee82

damodarguru commented 1 year ago

Verify the task in new build, The changes are reflecting as expected. Attaching the screenshots for reference.

Screenshots: image image image image image image image image image

Verified in: - Device: iPhone 8 OS:16.0.2 BLE version: 5.0 Inji app version:0.4.1 (29) -> TestFlight

Device: Redmi K20 Pro Android Version: 11 BLE version :5.0 Inji app link: https://github.com/mosip/inji/actions/runs/4447486079 Mimoto version: 1.2.0.1 MOSIP Version: qa-1201-b2.mosip.net

Kratitva commented 1 year ago

This is fixed as part of release v0.9.1