mosip / inji-wallet

MIT License
19 stars 83 forks source link

Modify the credential selection process during credential share #590

Closed nayakrounak closed 1 year ago

nayakrounak commented 1 year ago

Describe the bug The credential selection process needs to change during credential share.

Pre-requisite The application should have at least one credential to share.

To Reproduce Steps to reproduce the behaviour:

  1. Open the application
  2. Click on the QR code scanner
  3. Scan the verifier QR code to connect with the verifier application
  4. Share credential screen is shown below

Expected behaviour

Screenshots

image

Smartphone (please complete the following information): Not Applicable

Additional context Enhancement as discussed with Sasi on 24th Feb 2023.

nayakrounak commented 1 year ago

Hi @ravikp ,

For this ticket.

We need the auto-selection of the first credential to be fixed by Tomorrow.

The modification for highlighting the selected credential and removal of the radio button can come in later versions of the app.

Alka1703 commented 1 year ago

The following PRs implements auto selection of first VC on the consent page: PR for mosip/tuvali: https://github.com/mosip/tuvali/pull/28 PR for mosip/inji: https://github.com/mosip/inji/pull/595, https://github.com/mosip/inji/pull/597

The PRs have been merged in 28-02-2023 Release and the latest commit id on mosip/inji/develop is 7cdee82

vharsh commented 1 year ago

In the last release (28th Feb), we have addressed only

As part of the current release (6th Mar), The following UI enhancement improves UX by highlighting the selected VC with green border and eliminates the radio button from the VCs on share-screen.

PR for mosip/tuvali: https://github.com/mosip/tuvali/pull/29 PR for mosip/inji: https://github.com/mosip/inji/pull/615

The PRs have been merged in 06-03-2023 Release and the latest commit id on mosip/inji/develop is https://github.com/mosip/inji/commit/8867f3cc2dda5fb19c003f85524a8f5cfce61303

vharsh commented 1 year ago

The selected credential should be highlighted in green (colour may change based on theme)

@krishnakumar4a4 Right now the agreed upon colour is green for the VC border let me know if a change has been requested for the same.

Anuranjan14 commented 1 year ago

The selected credential is getting highlighted in green for both orange and purple themes and radio button from VC is removed. Attaching the screenshot for the reference. image CommitId: image

Kratitva commented 1 year ago

This is fixed as part of release v0.9.1