added dividing by frobenius norm

moskomule / anatome

Ἀνατομή is a PyTorch library to analyze representation of neural networks

MIT License

61 stars 6 forks source link

Closed brando90 closed 2 years ago

brando90 commented 2 years ago

added dividing by frobenius to make sims indepedent of scale as discussed here: https://github.com/moskomule/anatome/issues/12

brando90 commented 2 years ago

perhaps we need to change the places where _zero_mean is used to use _matrix_normalize.

brando90 commented 2 years ago

new update uses the correction, not sure if other places need change however...

brando90 commented 2 years ago

@moskomule per our discussion it seems the normalization I added is not neccessary? Just need to make sure that OP does normalized. Right?

moskomule commented 2 years ago

Yes, so I close this PR.