Closed brando90 closed 2 years ago
perhaps we need to change the places where _zero_mean
is used to use _matrix_normalize
.
new update uses the correction, not sure if other places need change however...
@moskomule per our discussion it seems the normalization I added is not neccessary? Just need to make sure that OP does normalized. Right?
Yes, so I close this PR.
added dividing by frobenius to make sims indepedent of scale as discussed here: https://github.com/moskomule/anatome/issues/12