search

moskomule / anatome

Ἀνατομή is a PyTorch library to analyze representation of neural networks
MIT License
61 stars 6 forks source link

Make resuls consistent with QR and SVD-based CCAs #28

Closed moskomule closed 2 years ago

moskomule commented 2 years ago

Found out that dividing inputs by their absolute max is important (probably makes it numerically stable?) https://github.com/google/svcca/blob/1f3fbf19bd31bd9b76e728ef75842aa1d9a4cd2b/cca_core.py#L285

brando90 commented 2 years ago

why did you divide by max? it doesn't seem to hurt in my experiments?

moskomule commented 2 years ago

I removed it and now the consistency is ok.