Closed moskomule closed 2 years ago
Found out that dividing inputs by their absolute max is important (probably makes it numerically stable?) https://github.com/google/svcca/blob/1f3fbf19bd31bd9b76e728ef75842aa1d9a4cd2b/cca_core.py#L285
why did you divide by max? it doesn't seem to hurt in my experiments?
I removed it and now the consistency is ok.
Found out that dividing inputs by their absolute max is important (probably makes it numerically stable?) https://github.com/google/svcca/blob/1f3fbf19bd31bd9b76e728ef75842aa1d9a4cd2b/cca_core.py#L285