moskomule / anatome

Ἀνατομή is a PyTorch library to analyze representation of neural networks
MIT License
61 stars 6 forks source link

error on import #9

Closed codestar12 closed 3 years ago

codestar12 commented 3 years ago

called

ran

import anatome

Traceback (most recent call last):

File "/home/cody/miniconda3/envs/RepDist/lib/python3.7/site-packages/IPython/core/interactiveshell.py", line 3437, in run_code exec(code_obj, self.user_global_ns, self.user_ns)

File "", line 1, in import anatome

File "/home/cody/miniconda3/envs/RepDist/lib/python3.7/site-packages/anatome/init.py", line 1, in from .similarity import SimilarityHook

File "", line 1 (x.size(0)=) ^ SyntaxError: invalid syntax

I have anatome==0.0.1 I can provide my environment info if needed but the error looks pretty clear.

codestar12 commented 3 years ago

can we change those f-strings to support 3.7?

moskomule commented 3 years ago

This library only supports Python 3.8 or higher. PRs are welcome.

codestar12 commented 3 years ago

It's a super simple change to make it 3.7 compatable. I cloned it and fixed it on my machine. I can put the pull request in after my paper deadline. I guess it depends on if wanting to support 3.7 is something you want to do.