search

mosn / holmes

self-aware Golang profile dumper
Apache License 2.0
1.06k stars 135 forks source link

a code issue in releases #120

Closed chrisLee1997 closed 1 year ago

chrisLee1997 commented 1 year ago

During my use, I found that there was a code issue in the v1.0.1 and v1.1.0 package, but there was no problem with the code here in the master branch of GitHub. Should type a new version of the tag？ holmes.go： Error code: func (h *Holmes) DisableMemDump() *Holmes { h.opts.gCHeapOpts.Enable = false return h } Correct code: func (h *Holmes) DisableMemDump() *Holmes { h.opts.memOpts.Enable = false return h }

Jun10ng commented 1 year ago

Thanks for your reminder. This API is not an important one. So it doesn't influent our release plan. cmiiww @doujiang24

doujiang24 commented 1 year ago

Thanks, just kick out the new v1.0.2 release, closing it.