兼容新版本接口(inuse_objects和inuse_space的上报处理)

mosn / holmes

self-aware Golang profile dumper

Apache License 2.0

1.06k stars 135 forks source link

Closed fibbery closed 10 months ago

fibbery commented 10 months ago

使用pyroscope v0.37.2测试发现，heap信息上报之后，在pyroscope找不到inuse_space和inuse_objects，发现pyroscope api有所更新，所以兼容处理一下

Jun10ng commented 10 months ago

Hi, fibbery, 感谢你的PR，我看了下pyscope最近的release，已经从v0.37.2升级到 v1.0.0了，我们能否测试下这次的改动是否适配1.0呢？我理解pyscope 1.0之后有broken change可能性不大。

fibbery commented 10 months ago

Hi, fibbery, 感谢你的PR，我看了下pyscope最近的release，已经从v0.37.2升级到 v1.0.0了，我们能否测试下这次的改动是否适配1.0呢？我理解pyscope 1.0之后有broken change可能性不大。

测试过了，同一个测试用例跑的，这两个版本没看到有兼容行问题。

ps: 感觉response.code的状态码处理方式有点问题，经常看不出来报错是什么

Jun10ng commented 10 months ago

Hi @doujiang24, do u think we need release a new tag for this change? It compatibles Pyscope v1.0.

doujiang24 commented 10 months ago

@Jun10ng Yep, I do think it deserves it.